Repository navigation
Conversation
Review of the stale ja/refactoring/1 branch against current main: the branch cannot be rebased (mat_writer, step_d_workflow, dic_analysis all rewritten by #21/#32/#36/#37), but its matio_helpers, checkpoint-policy and DIC2D service interfaces survive as specs. Re-planned as phased extractions against today's code, accounting for staged execution and the cuNCorr engine seam. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
johnaoga
marked this pull request as ready for review
July 5, 2026 17:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second refactoring round, replacing the stale
ja/refactoring/1(#11) which forked ate7723be— before newversion (#21), SLURM staging (#24/#32), logging (#29), webgui (#31), video perf (#35), optional apps (#36), matlab-parallel (#37) and the cuNCorr engine integration. That branch cannot be rebased (every file it touched was rewritten), but several of its designs survive as specs.This PR starts with the plan document (docs/refactoring_plan.md); implementation commits will follow on this branch. A companion plan/PR exists in the CppNCorr submodule (xdic-dev/CppNCorr#19).
Review of round 1
matio_helpers(clean, xDIC-agnostic matio wrapper layer).CheckpointPolicy, guard-test patterns.PipelineRunner(too thin for today's mode × stage dispatch),cppxdic::namespace tree + CMake restructure (extract first, namespace later).Plan
matio_helperscherry-pick;CheckpointPolicycentralizing stage-artifact checks now duplicated acrossstep_d_workflow.cppanddic_analysis.cpp(contract for feat(cluster): stage-decomposable pipeline (--stages) + SLURM array scripts #32 SLURM staging).mat_writer.cpp(2721 → ~600 ln) intosrc/io/mat/codecs; binary-format parity guarded by existing tests.step_d_workflow.cpp(1352 → ~300 ln) into frame-preparer / ROI-seed / matching / tracking services; formalize the DIC-engine interface shared by CppNCorr and cuNCorr.Guardrails: behavior-preserving moves only, tests + staged-pipeline smoke green per step, checkpoint file paths treated as a compatibility contract. Sequencing note: coordinate with
feat/cuncorr-integrationbefore touching the DIC2D call sites it modifies.Supersedes #11.
🤖 Generated with Claude Code